Update ledger candid path #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
peterpeterparker
added a commit
to dfinity/oisy-wallet
that referenced
this pull request
Oct 21, 2024
) # Motivation The `rosetta-api` path was renamed and restructured to `ledger_suite` in the IC main repo. Therefore we have to update the paths to download the ICP and ICRC ledger and index did files. # Notes Detected in ic-js and fixed in PR dfinity/ic-js#736 # Changes - Update path as in [https://github.com/dfinity/ic/tree/master/rs/ledger_suite](https://github.com/dfinity/ic/tree/master/rs/ledger_suite)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The "Update IC" workflow failed because ledger and Index Candid files were moved to a different directory in dfinity/ic#1682
Changes
Updated
scripts/import-candidto copy the ledger candid files from the new path.Tests
Manually ran
./scripts/import-candid ../../icto see that it works again.Todos
not necessary