Update old_list_neurons_service.certified.idl.js #729
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The purpose of
old_list_neurons_service.certified.idl.js
is to have the request type be supported by Ledger HW ICP app version 2.4.9.The hardware wallet does care about the response type so it is safe to update.
We want to include
visibility
specifically.Changes
Recreate
old_list_neurons_service.certified.idl.js
the same way it was created the first time as documented by the comment at the top:The result is that the
visibility
field was added in addition to field names now being wrapped in''
.Tests
Used manually with nns-dapp and was able to
visibility
in the response.Todos
not necessary