Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nns-js Candid Files #715

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Update nns-js Candid Files #715

merged 3 commits into from
Sep 9, 2024

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Sep 9, 2024

Motivation

We want to keep Candid files in ic-js in sync with the IC repo.
This is normally done by automated jobs, but the changes from dfinity/ic#1157 caused tests to break in the latest automated update.

Changes

  1. Ran git pull in ../../ic
  2. Ran scripts/import-candid ../../ic
  3. Ran scripts/compile-idl-js
  4. Removed OpenSnsTokenSwap, SetSnsTokenSwapOpenTimeWindow, and SetDefaultFollowees from ProposalActionRequest in packages/nns/src/canisters/governance/request.converters.ts.
  5. Remove OpenSnsTokenSwap, SetSnsTokenSwapOpenTimeWindow, and SetDefaultFollowees from Action in packages/nns/src/types/governance_converters.ts.
  6. Reverted the changes in packages other than nns.

Tests

  1. Tests pass.
  2. Tested that tests pass in NNS dapp after updating to ic-js with the new changes.

Todos

  • Add entry to changelog (if necessary).

Copy link
Contributor

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.99 KB (0%)
@dfinity/cketh 3.45 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 4.17 KB (0%)
@dfinity/ledger-icp 15.43 KB (0%)
@dfinity/nns 36.25 KB (-0.64% 🔽)
@dfinity/nns-proto 140.98 KB (0%)
@dfinity/sns 15.92 KB (0%)
@dfinity/utils 4.5 KB (0%)
@dfinity/ic-management 2.92 KB (0%)

@dskloetd dskloetd marked this pull request as ready for review September 9, 2024 07:03
@dskloetd dskloetd requested review from a team as code owners September 9, 2024 07:03
@dskloetd dskloetd closed this Sep 9, 2024
@dskloetd dskloetd reopened this Sep 9, 2024
@dskloetd dskloetd enabled auto-merge (squash) September 9, 2024 16:09
@dskloetd dskloetd merged commit e7fa676 into main Sep 9, 2024
21 checks passed
@dskloetd dskloetd deleted the kloet/bump-set-sns branch September 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants