-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ckEth orchestrator #632
Conversation
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
…at/cketh-orchestrator
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
Signed-off-by: David Dal Busco <[email protected]>
size-limit report 📦
|
Signed-off-by: David Dal Busco <[email protected]>
…at/cketh-orchestrator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm curious, why do you fetch the cERC20 tokens with a periodic job in Oisy? Are the tokens coming from the backend then?
ckErc20 will require some additional information, such as their logo for Ethereum, which, unlike on the IC, is not provided by their respective smart contracts, so, it probably will still requires a bit of manual review/work. We also periodically fetch and embed information statically, such as for Snses, rather than dynamically at runtime. This approach ensures that the UX/UI does not feel glitchy, as it does in the NNS dapp. While this may result in a delay of a few days before new tokens are available, it has no functional downsides since users can add custom tokens. Thanks for the review! |
Closed and reopened the PR to restart the checks that were stuck. |
Motivation
Add the ckEth orchestrator (source) to
@dfinity/ledger-cketh
and expose functionget_orchestrator_info
.This additional canister is responsible for spinning up Ledger and Index canisters for ckERC20 tokens when (and if) the respective proposals are approved and executed (for example, proposal 129750).
One might want to use this canister to fetch at runtime the list of ledgers and indexes or the list of supported ckERC20 tokens, but most probably, as in Oisy, one might use this feature to set up a job that periodically checks automatically if new tokens were approved and deployed.
Changes
orchestrator.did
CkETHOrchestratorCanister
(no particular options)get_orchestrator_info
(nothing particular, readonly function)docs.js
to generate its documentation