Fix TokenAmountV2.fromNumber for decimals < 8 #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
May 16, 2024
# Motivation Pull in the fix for tokens with <8 decimals (for ckUSDC) from dfinity/ic-js#629 # Changes Ran `npm run upgrade:next`. # Tests not tested # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When creating a
TokenAmountV2from anumber, we first convert it to a string with 8 decimals.When the number has more decimals, they are just truncated. But number input components in gix-components don't allow more than 8 decimals.
But when the token allows fewer than 8 decimals, this results in an error.
The happened to be one of the few combinations without a unit test but will be needed for ckUSDC.
Changes
When converting the number to a string with a fixed number of decimals, instead of always using 8 decimals, use the minimum of 8 and the number of decimals the token allows.
Tests
Todos