Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ckETH most recent Candid types #624

Merged
merged 1 commit into from
May 13, 2024
Merged

feat: update ckETH most recent Candid types #624

merged 1 commit into from
May 13, 2024

Conversation

peterpeterparker
Copy link
Member

Motivation

Update ckETH Candid types as proposed by PR #623 and add new optional minter info fields to test mock data.

Changes

@peterpeterparker peterpeterparker requested a review from dskloetd May 13, 2024 06:19
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@dfinity/ckbtc 7.24 KB (0%)
@dfinity/cketh 2.94 KB (+4.12% 🔺)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.6 KB (0%)
@dfinity/ledger-icp 14.73 KB (0%)
@dfinity/nns 34.55 KB (0%)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.72 KB (0%)
@dfinity/utils 4.46 KB (0%)
@dfinity/ic-management 2.58 KB (0%)

dskloetd
dskloetd approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 671634c into main May 13, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/cketh-types branch May 13, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @dskloetd