Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish 'next' every night. #605

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Do not publish 'next' every night. #605

merged 1 commit into from
Apr 3, 2024

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Apr 3, 2024

Motivation

Whenever we make changes to ic-js, we almost always do a manual "Next Publication" in order to pull the new changes into another repo.
Having an addition "Next Publication" every night does not really provide value.
And not having frequent next publications actually makes it easier to see when you've forgotten to do a publication before updating the gix-components dependency in another repo.

Changes

  1. Remove the scheduled runs of "Next Publication".
  2. Rename nightly.yml to next.yml to reflect the purpose more accurately.

@dskloetd dskloetd marked this pull request as ready for review April 3, 2024 12:43
Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.29 KB (0%)
@dfinity/cketh 2.17 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.4 KB (0%)
@dfinity/ledger-icp 14.77 KB (0%)
@dfinity/nns 34.35 KB (0%)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.43 KB (0%)
@dfinity/utils 4.44 KB (0%)
@dfinity/ic-management 2.61 KB (0%)

Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dskloetd dskloetd merged commit eaca602 into main Apr 3, 2024
11 checks passed
@dskloetd dskloetd deleted the kloet/nightly-next branch April 3, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants