Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-2886: Remove nns-proto dependency from @dfinity/nns #599

Merged
merged 5 commits into from
Mar 28, 2024
Merged

NNS1-2886: Remove nns-proto dependency from @dfinity/nns #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbd049e
Remove nns-proto dependency from @dfinity/nns
dskloetd Mar 27, 2024
e2b6dfc
changelog
dskloetd Mar 27, 2024
2fc4051
🤖 Documentation auto-update
github-actions[bot] Mar 27, 2024
fcd0d11
changelog2
dskloetd Mar 28, 2024
eb9d870
FeatureNotSupportedError
dskloetd Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,14 @@
- Remove hardware wallet specific code paths from `@dfinity/ledger-icp`.
- Remove hardware wallet specific options from LedgerCanister.
- Remove dependency on `@dfinity/nns-proto` from `@dfinity/ledger-icp`.
- Remove hardware wallet specific code and `@dfinity/nns-proto` dependency from `@dfinity/nns`.

# Breaking changes

- Protocol buffers for hardware wallet transactions are no longer supported.
Internet Computer Ledger app 2.4.9 or later is now required.
- GovernanceCanister.listNeurons no longer throws an error when called with
`certified: false` for hardware wallet transactions.

# 2024.03.25-1430Z

Expand Down
1 change: 0 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

64 changes: 32 additions & 32 deletions packages/nns/README.md
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion packages/nns/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/ledger-icp": "^2.2.2",
"@dfinity/nns-proto": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/utils": "^2.1.3"
}
Expand Down
277 changes: 0 additions & 277 deletions packages/nns/src/canisters/governance/request.proto.converters.ts
View file
Open in desktop

This file was deleted.

Loading
Loading