Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-2886: Remove hardware wallet specific code paths from ledger-icp #595

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

dskloetd
Copy link
Collaborator

Motivation

The NNS dapp now requires version 2.4.9 of the Internet Computer Ledger app.
See for context: https://forum.dfinity.org/t/nns-dapp-to-remove-protobuf-dependency-upgrade-your-ledger-ic-app-to-2-4-9/27712
This means that we no longer need to use a separate code path with protocol buffers when making hardware wallet transactions but can instead use the exact same code path as for normal transactions.

NNS-dapp already doesn't use hardware wallet specific code paths since dfinity/nns-dapp#4373

Changes

  1. Remove all code paths in packages/ledger-icp that check this.hardwareWallet.
  2. Remove all functions that became unused as a result.

Tests

Remove hardware wallet specific unit tests.

Todos

  • Add entry to changelog (if necessary).

Copy link
Contributor

github-actions bot commented Mar 27, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.29 KB (0%)
@dfinity/cketh 2.17 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.4 KB (0%)
@dfinity/ledger-icp 15.18 KB (-4.06% 🔽)
@dfinity/nns 35.73 KB (-0.03% 🔽)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.43 KB (0%)
@dfinity/utils 4.44 KB (0%)
@dfinity/ic-management 2.61 KB (0%)

@dskloetd dskloetd marked this pull request as ready for review March 27, 2024 13:48
@dskloetd dskloetd requested a review from mstrasinskis March 27, 2024 13:55
Base automatically changed from kloet/default-fee to main March 27, 2024 14:26
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question.

packages/ledger-icp/src/ledger.canister.ts Show resolved Hide resolved
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dskloetd dskloetd enabled auto-merge (squash) March 27, 2024 15:07
@dskloetd dskloetd merged commit f844f24 into main Mar 27, 2024
11 checks passed
@dskloetd dskloetd deleted the kloet/hw-path branch March 27, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants