Update candid in ledger-icp package #592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ICP transactions, as provided by the Index canister, have been extended to include their block timestamp information.
Changes
Ran the following to update all candid and then undo everything except the
ledger-icp
package.Tests
Included transaction data in the test transactions in the unit test.
The transactions are returned exactly as returned from the canister but this should help with test coverage in case that ever changes in the future.
Todos