Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update candid in ledger-icp package #592

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Update candid in ledger-icp package #592

merged 3 commits into from
Mar 26, 2024

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Mar 26, 2024

Motivation

ICP transactions, as provided by the Index canister, have been extended to include their block timestamp information.

Changes

Ran the following to update all candid and then undo everything except the ledger-icp package.

scripts/import-candid ../../ic
scripts/compile-idl-js
git checkout packages/{sns,nns,ic-management,cmc,cketh,ckbtc}

Tests

Included transaction data in the test transactions in the unit test.
The transactions are returned exactly as returned from the canister but this should help with test coverage in case that ever changes in the future.

Todos

  • Add entry to changelog (if necessary).

Copy link
Contributor

github-actions bot commented Mar 26, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.29 KB (0%)
@dfinity/cketh 2.17 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.4 KB (0%)
@dfinity/ledger-icp 15.85 KB (+0.02% 🔺)
@dfinity/nns 35.74 KB (0%)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.43 KB (0%)
@dfinity/utils 4.44 KB (0%)
@dfinity/ic-management 2.61 KB (0%)

@dskloetd dskloetd marked this pull request as ready for review March 26, 2024 08:20
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@dskloetd dskloetd enabled auto-merge (squash) March 26, 2024 09:40
@dskloetd dskloetd merged commit 422b470 into main Mar 26, 2024
11 checks passed
@dskloetd dskloetd deleted the kloet/candid-timestamp branch March 26, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants