-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: xdr_conversion_rate and neurons fund economics for NNS governance #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…funds' into feat/xdr_conversion_rate-neuron-funds
size-limit report 📦
|
Signed-off-by: David Dal Busco <[email protected]>
mstrasinskis
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question regarding switching to blob
type.
dskloetd
reviewed
Apr 2, 2024
Signed-off-by: David Dal Busco <[email protected]>
dskloetd
approved these changes
Apr 2, 2024
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Apr 3, 2024
# Motivation Bump ic-js next which contains the [PR](dfinity/ic-js#585) that bumps did files and the xdr_conversion_rate and neurons fund economics for NNS governance in nns-js. # Changes - `npm run upgrade:next`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update NNS governance did files which adds information
xdr_conversion_rate
andNeuronsFundEconomics
.Notes
According did file exposed in the Dashboard, all those types are already live on mainnet.
https://dashboard.internetcomputer.org/canister/rrkah-fqaaa-aaaaa-aaaaq-cai
Changes
message: []
for make proposal in spec file