Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: xdr_conversion_rate and neurons fund economics for NNS governance #585

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Mar 25, 2024

Motivation

Update NNS governance did files which adds information xdr_conversion_rate and NeuronsFundEconomics.

Notes

According did file exposed in the Dashboard, all those types are already live on mainnet.

https://dashboard.internetcomputer.org/canister/rrkah-fqaaa-aaaaa-aaaaq-cai

Changes

  • update did file from Update Candid Files #581
  • adapt request and response parsers
  • add message: [] for make proposal in spec file

Copy link
Contributor

github-actions bot commented Mar 25, 2024

size-limit report 📦

Path Size
@dfinity/ckbtc 7.29 KB (0%)
@dfinity/cketh 2.17 KB (0%)
@dfinity/cmc 1.29 KB (0%)
@dfinity/ledger-icrc 3.4 KB (0%)
@dfinity/ledger-icp 14.77 KB (0%)
@dfinity/nns 34.35 KB (+2.09% 🔺)
@dfinity/nns-proto 76.44 KB (0%)
@dfinity/sns 15.43 KB (0%)
@dfinity/utils 4.44 KB (0%)
@dfinity/ic-management 2.61 KB (0%)

@peterpeterparker peterpeterparker mentioned this pull request Apr 1, 2024
1 task
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question regarding switching to blob type.

packages/nns/candid/governance.did Show resolved Hide resolved
packages/nns/candid/governance.did Show resolved Hide resolved
@peterpeterparker peterpeterparker merged commit 8fbd176 into main Apr 3, 2024
11 checks passed
@peterpeterparker peterpeterparker deleted the feat/xdr_conversion_rate-neuron-funds branch April 3, 2024 06:13
github-merge-queue bot pushed a commit to dfinity/nns-dapp that referenced this pull request Apr 3, 2024
# Motivation

Bump ic-js next which contains the
[PR](dfinity/ic-js#585) that bumps did files and
the xdr_conversion_rate and neurons fund economics for NNS governance in
nns-js.

# Changes

- `npm run upgrade:next`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants