Add retrieveBtcStatusV2ByAccount to ckbtc canister #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lmuntaner
approved these changes
Dec 14, 2023
| * Returns the status of all BTC withdrawals for the user's main account. | ||
| * | ||
| * @param {bigint} transactionId The ID of the corresponding burn transaction. | ||
| * @param {boolean} certified query or update call |
There was a problem hiding this comment.
Could you add the return type and a short explanation?
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Dec 14, 2023
# Motivation Use `retrieveBtcStatusV2ByAccount` added in dfinity/ic-js#503 # Changes Ran `npm run upgrade:next` # Tests Manually tested in a separate branch. # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
I want to use this to display BTC withdrawal transactions in nns-dapp as pending or failed when appropriate.
Tests
Unit tests added.
Tested manually in an nns-dapp branch.
Todos