fix: utilize ICP Index accountBalance and getTransactions with account identifier hex directly

CHANGELOG.md

@@ -15,6 +15,10 @@
 - Add a new type TokenAmountV2 which supports `decimals !== 8`.
 - Fix issue when converting token amount from small numbers with `TokenAmountV2`.
 
+## Fix
+
+- Utilize ICP Index `accountBalance` and `getTransactions` with account identifier hex directly, eliminating the need for conversion with Buffer and resolving usage in non-polyfilled environments.
+
 ## Operations
 
 - Add a cron job to periodically update IC candid files and typescript bindings.

packages/ledger-icp/src/index.canister.ts

@@ -14,7 +14,7 @@ import { MAINNET_INDEX_CANISTER_ID } from "./constants/canister_ids";
 import { IndexError } from "./errors/index.errors";
 import type { GetTransactionsParams } from "./types/index.params";
 import type { AccountBalanceParams } from "./types/ledger.params";
-import { paramToAccountIdentifier } from "./utils/params.utils";
+import { paramToAccountIdentifierHex } from "./utils/params.utils";
 
 export class IndexCanister extends Canister<IndexService> {
   static create({
@@ -47,7 +47,7 @@ export class IndexCanister extends Canister<IndexService> {
     accountIdentifier,
   }: AccountBalanceParams): Promise<bigint> =>
     this.caller({ certified }).get_account_identifier_balance(
-      paramToAccountIdentifier(accountIdentifier).toHex(),
+      paramToAccountIdentifierHex(accountIdentifier),
     );
 
   /**
@@ -70,7 +70,7 @@ export class IndexCanister extends Canister<IndexService> {
     const response = await this.caller({
       certified,
     }).get_account_identifier_transactions({
-      account_identifier: paramToAccountIdentifier(accountIdentifier).toHex(),
+      account_identifier: paramToAccountIdentifierHex(accountIdentifier),
       start: toNullable(start),
       max_results,
     });

packages/ledger-icp/src/utils/params.utils.ts

@@ -1,7 +1,13 @@
 import { AccountIdentifier } from "../account_identifier";
+import type { AccountIdentifierHex } from "../types/common";
 import type { AccountIdentifierParam } from "../types/ledger.params";
 
 export const paramToAccountIdentifier = (
   param: AccountIdentifierParam,
 ): AccountIdentifier =>
   param instanceof AccountIdentifier ? param : AccountIdentifier.fromHex(param);
+
+export const paramToAccountIdentifierHex = (
+  param: AccountIdentifierParam,
+): AccountIdentifierHex =>
+  param instanceof AccountIdentifier ? param.toHex() : param;