-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix: IDL paths to Index from Ledger #493
Conversation
IDL paths for IndexCanister are pointing to ledger canister idls instead of Index
Dear @cozmbatman, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1. If you decide to agree with it, please visit this issue and read the instructions there. — The DFINITY Foundation Footnotes
|
Dear @cozmbatman, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
Sounds good to me. If you can accept the CLA @cozmbatman, I'm happy to go on and merge this. |
@peterpeterparker i already did accept the CLA, i believe bot added the 'cla:agreed' tag after that. |
Thanks for the feedback. I just gonna try to close the PR and reopen it to hopefully re-trigger the CLA bot correctly. |
The CLA looks good now. The size-limit checker fails with following reason:
However, I checked the output and all limits are met. Therefore I'll go on an merge the PR. |
Thanks for the PR @cozmbatman 👍 |
IDL paths for IndexCanister are pointing to ledger canister idls instead of Index
Motivation
Bug fix, regression, IDL paths in Index Cannister are pointing to Ledger instead of Index.
Changes
Updated loading path info for IDLs
Tests
Todos