Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: IDL paths to Index from Ledger #493

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

cozmbatman
Copy link
Contributor

IDL paths for IndexCanister are pointing to ledger canister idls instead of Index

Motivation

Bug fix, regression, IDL paths in Index Cannister are pointing to Ledger instead of Index.

Changes

Updated loading path info for IDLs

Tests

Todos

  • Add entry to changelog (if necessary).

IDL paths for IndexCanister are pointing to ledger canister idls instead of Index
@ghost
Copy link

ghost commented Dec 3, 2023

Dear @cozmbatman,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA1.

If you decide to agree with it, please visit this issue and read the instructions there.

— The DFINITY Foundation

Footnotes

  1. Contributor License Agreement

@sa-github-api
Copy link
Collaborator

Dear @cozmbatman,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@ghost ghost added cla:agreed and removed cla:pending labels Dec 3, 2023
@peterpeterparker
Copy link
Member

Sounds good to me. If you can accept the CLA @cozmbatman, I'm happy to go on and merge this.

@cozmbatman
Copy link
Contributor Author

@peterpeterparker i already did accept the CLA, i believe bot added the 'cla:agreed' tag after that.

@peterpeterparker
Copy link
Member

Thanks for the feedback. I just gonna try to close the PR and reopen it to hopefully re-trigger the CLA bot correctly.

@peterpeterparker
Copy link
Member

The CLA looks good now.

The size-limit checker fails with following reason:

Error creating comment. This can happen for PR's originating from a fork without write permissions.
Error: Size limit has been exceeded.

However, I checked the output and all limits are met. Therefore I'll go on an merge the PR.

@peterpeterparker peterpeterparker merged commit ac1bbf0 into dfinity:main Dec 3, 2023
18 of 21 checks passed
@peterpeterparker
Copy link
Member

Thanks for the PR @cozmbatman 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants