feat: makeProposal return created proposal ID #486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
makeProposal
returns currently void which is a bit inconvenient if the caller needs to know which proposal was created which happens to be the case in the small proof of concept I was developing.Therefore this PR extends the function to return the potential ID of the proposal that was created.
Notes
Given the fact that the answer of the Governance canister is a variant I hesitated between returning
Promise<bigint | undefined>
or{success: boolean; proposalId?: bigint}
. Given the fact that there was no use cases where `success: false^ would be set, I opted for the first simple solution.Changes
Command_1
formanageNeuron
makeProposal
manageNeuron
continue returningvoid