Support number[] in uint8ArrayToHexString #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
| bytes.reduce((str, byte) => str + byte.toString(16).padStart(2, "0"), ""); | ||
| export const uint8ArrayToHexString = (bytes: Uint8Array | number[]) => { | ||
| if (!(bytes instanceof Uint8Array)) { | ||
| bytes = Uint8Array.from(bytes); |
There was a problem hiding this comment.
nice to have: it would be nice to not mutate the provided variables but to realocate for a more functional approach (?).
cont b = bytes instanceof Unit8Array ? bytes : Uint8Array.from(bytes);
return b.reduce(...
There was a problem hiding this comment.
It doesn't really make a difference to me but since it's already merged, I'll accept your PR :-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Candid changed what used to be
Uint8ArraytoUint8Array | number[].This means we often have to convert a field to
Uint8Arrayjust to get rid of the| number[]bit.To make this slightly less painful we can make some functions accept both.
Changes
Make
uint8ArrayToHexStringaccept bothUint8Array | number[].I considered changing the name but in that case I don't think it's worth it anymore. What do you think?
Tests
Unit test added
Todos