Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retrieveBtcStatus to ckbtc minter #481

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Add retrieveBtcStatus to ckbtc minter #481

merged 5 commits into from
Nov 23, 2023

Conversation

dskloetd
Copy link
Collaborator

Motivation

To query the status of a BTC withdrawal the ckBTC minter has a method called retrieve_btc_status.

Changes

Expose retrieveBtcStatus on the minter canister.

Tests

Unit test added.
Tested manually in NNS dapp.

Todos

  • Add entry to changelog (if necessary).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.88 KB (+0.38% 🔺)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.83 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.92 KB (0%)
@dfinity/utils 4.12 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@dskloetd dskloetd marked this pull request as ready for review November 22, 2023 16:30
lmuntaner
lmuntaner approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dskloetd dskloetd enabled auto-merge (squash) November 23, 2023 08:28
@dskloetd dskloetd merged commit 10c75f1 into main Nov 23, 2023
12 checks passed
@dskloetd dskloetd deleted the kloet/retrieve-btc-status branch November 23, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @lmuntaner