Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Improve admin docs #479

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Chore: Improve admin docs #479

merged 3 commits into from
Nov 22, 2023

Conversation

lmuntaner
Copy link
Contributor

Motivation

Improve docs.

Changes

  • Changes in ADMIN.md

Tests

Only docs changes.

Todos

  • Add entry to changelog (if necessary).

Not necessary.

@lmuntaner
Copy link
Contributor Author

@peterpeterparker please review

In the 3rd step:

To open next version afterward, bump the libraries' version and add a note in CHANGELOG.

Should I do a patch bump on all libraries? Is that necessary? The changelog I changed it in the previous PR.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.86 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.82 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.92 KB (0%)
@dfinity/utils 4.12 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

peterpeterparker
peterpeterparker reviewed Nov 22, 2023
View reviewed changes
ADMIN.md Outdated Show resolved Hide resolved
ADMIN.md Outdated Show resolved Hide resolved
@lmuntaner
Copy link
Contributor Author

@peterpeterparker ready for another review

peterpeterparker
peterpeterparker approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@peterpeterparker peterpeterparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lmuntaner lmuntaner merged commit b627be1 into main Nov 22, 2023
12 checks passed
@lmuntaner lmuntaner deleted the chore_LM_improve-admin-docs branch November 22, 2023 13:31
@lmuntaner lmuntaner added the Planned Work planned in the Sprint label Nov 22, 2023 — with Graphite App
@lmuntaner lmuntaner restored the chore_LM_improve-admin-docs branch November 27, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker peterpeterparker approved these changes

Assignees
No one assigned
Labels
Planned Work planned in the Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @peterpeterparker