Expose pending UTXOs returned by the minter #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
github-merge-queue bot
pushed a commit
to dfinity/nns-dapp
that referenced
this pull request
Nov 21, 2023
# Motivation Pull in the changes from dfinity/ic-js#477 to forward pending UTXOs from the minter. # Changes ## Automated Ran `npm run upgrade:next` ## Manual Added required constructor parameters to `MinterNoNewUtxosError`. # Tests Existing tests pass. # Todos - [ ] Add entry to changelog (if necessary). not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we call
update_balaceon the ckBTC minter, it will credit deposited BTC from transactions with at least 12 confirmations.If there are no new transactions with at least 12 confirmations, it will return an error.
If there are transactions with fewer than 12 confirmations, the error will contain the pending UTXOs of those transaction.
Changes
Forward the pending UTXOs returned by the minter, in the mapped error.
Tests
Existing unit test has been updated.
Todos