-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Upgrade didc #474
Chore: Upgrade didc #474
Conversation
size-limit report 📦
|
Could you point out where this was needed, please? Are both didc and manual changes in the first commit? I guess I can run didc and see whether there is a diff between the output and what is committed. |
Sorry, I should have split the changes by commits. All the files inside a |
Sorry, I missed that. The changes look plausible to me. Thanks! |
@peterpeterparker please review |
Motivation
Keep tools up to date.
In this PR, upgrade
didc
to latest version0.3.5
.The change is that types of
Uint8Array
are nowUint8Array | number[]
.Which means that in some places I had to convert to
Uint8Array
to have a common type for simplicity.Changes
Automatic changes
*/candid/*
directories. By runningcompile-idl-js
with the newdidc
version.Manual changes
compile-idl-js
to expect latestdidc
.Uint8Array | number[]
toUint8array
withUint8Array.from
where needed.Tests
Still passing.
Todos