Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade didc #474

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Chore: Upgrade didc #474

merged 6 commits into from
Nov 20, 2023

Conversation

lmuntaner
Copy link
Contributor

@lmuntaner lmuntaner commented Nov 16, 2023

Motivation

Keep tools up to date.

In this PR, upgrade didc to latest version 0.3.5.

The change is that types of Uint8Array are now Uint8Array | number[].

Which means that in some places I had to convert to Uint8Array to have a common type for simplicity.

Changes

Automatic changes

  • All files in */candid/* directories. By running compile-idl-js with the new didc version.
  • Readme files with the docs workflow.

Manual changes

  • compile-idl-js to expect latest didc.
  • Convert types Uint8Array | number[] to Uint8array with Uint8Array.from where needed.

Tests

Still passing.

Todos

  • Add entry to changelog (if necessary).

@lmuntaner lmuntaner changed the title Chore lm upgrade didc Chore: Upgrade didc Nov 16, 2023
@lmuntaner lmuntaner added the Planned Work planned in the Sprint label Nov 16, 2023
Copy link
Contributor

github-actions bot commented Nov 16, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.79 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (+0.14% 🔺)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.82 KB (+0.03% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.92 KB (+0.06% 🔺)
@dfinity/utils 4.12 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@bitdivine
Copy link
Member

Which means that in some places I had to convert to Uint8Array to have a common type for simplicity.

Could you point out where this was needed, please? Are both didc and manual changes in the first commit? I guess I can run didc and see whether there is a diff between the output and what is committed.

@lmuntaner
Copy link
Contributor Author

  • All files in */candid/* directories. By running compile-idl-js with the new didc version.

Sorry, I should have split the changes by commits.

All the files inside a candid directory were automatic changes by didc. The rest (except readme files) are manual changes. You need to look at the file directory.

@bitdivine
Copy link
Member

Sorry, I missed that. The changes look plausible to me. Thanks!

@lmuntaner lmuntaner marked this pull request as ready for review November 20, 2023 07:22
@lmuntaner
Copy link
Contributor Author

@peterpeterparker please review

@lmuntaner lmuntaner merged commit 3076126 into main Nov 20, 2023
10 checks passed
@lmuntaner lmuntaner deleted the chore_LM_upgrade-didc branch November 20, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Planned Work planned in the Sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants