Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ICP index canister getTransactions #466

Merged
merged 4 commits into from
Nov 14, 2023
Merged

feat: ICP index canister getTransactions #466

merged 4 commits into from
Nov 14, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

Add support to fetch transactions with the ICP Index canister.

Changes

  • introduce get_account_identifier_transactions

@peterpeterparker peterpeterparker changed the title Feat/index icp get account balance feat: ICP index canister getTransactions Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.79 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (+0.59% 🔺)
@dfinity/nns 33.81 KB (+0.01% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.91 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@peterpeterparker peterpeterparker marked this pull request as ready for review November 14, 2023 06:33
@peterpeterparker peterpeterparker added the enhancement New feature or request label Nov 14, 2023
lmuntaner
lmuntaner approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 8a6f5d9 into main Nov 14, 2023
9 checks passed
@peterpeterparker peterpeterparker deleted the feat/index-icp-get-account-balance branch November 14, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner