New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix publish script #441

Merged

peterpeterparker merged 1 commit into main from build/fix-publish

Oct 2, 2023

Member

peterpeterparker commented Oct 2, 2023

Motivation

Ledger-icrc/icp were not published to npm because the brand new publish script was not updated with their path.

https://github.com/dfinity/ic-js/actions/runs/6381951349/job/17319506306


          build: fix publish script

baf548e

peterpeterparker requested a review from lmuntaner

October 2, 2023 15:34

Contributor

github-actions bot commented Oct 2, 2023

size-limit report 📦

Path	Size
@dfinity/ckbtc	6.38 KB (0%)
@dfinity/cmc	1.01 KB (0%)
@dfinity/ledger-icrc	2.92 KB (0%)
@dfinity/ledger-icp	14.17 KB (0%)
@dfinity/nns	29.41 KB (0%)
@dfinity/nns-proto	76.3 KB (0%)
@dfinity/sns	14.86 KB (0%)
@dfinity/utils	3.81 KB (0%)
@dfinity/ic-management	1.94 KB (0%)

lmuntaner approved these changes

View reviewed changes

Contributor

lmuntaner left a comment

Thanks!

peterpeterparker merged commit 90a4167 into main

9 checks passed

peterpeterparker deleted the build/fix-publish branch

October 2, 2023 15:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet