Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix docs ledger-icp #438

Merged
merged 3 commits into from
Oct 2, 2023
Merged

build: fix docs ledger-icp #438

merged 3 commits into from
Oct 2, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

I probably had a merge conflicts which leads the paths for the ledger-icp doc generation to point to nns.

Changes

  • fix doc generation for ledger-icp

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.17 KB (0%)
@dfinity/nns 29.41 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.86 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

lmuntaner
lmuntaner approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit c45799d into main Oct 2, 2023
@peterpeterparker peterpeterparker deleted the build/fix-ledger-icp branch October 2, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner