Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: v1 and semantic versioning #431

Merged
merged 4 commits into from
Oct 2, 2023
Merged

build: v1 and semantic versioning #431

merged 4 commits into from
Oct 2, 2023

Conversation

peterpeterparker
Copy link
Member

Motivation

Bump versions to v1.0.0 and commit to start adopting semantic versioning.

This PR also set the release dates in CHANGELOG that way we can effectively release v1 today.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger 2.92 KB (0%)
@dfinity/ledger-icp 0 B (-100% 🔽)
@dfinity/nns 29.79 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.85 KB (0%)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

CHANGELOG.md Show resolved Hide resolved
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea!

@peterpeterparker peterpeterparker merged commit 21a73b7 into main Oct 2, 2023
9 checks passed
@peterpeterparker peterpeterparker deleted the build/v1 branch October 2, 2023 09:36
peterpeterparker added a commit that referenced this pull request Oct 2, 2023
# Motivation

So far, we've been incrementing the version of all libraries when we publish, even if some of them received no improvements or fixes. I find this approach a bit cumbersome. Since I propose to commit to semantic versioning (#431), a better approach would be most welcomed. That's why this PR introduces a publication script that handles the publishing of libraries only if they were actually modified.

# Changes

- use `shasum` to compare local library with npm and publish only upon differences
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants