Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIX-1909: Update candid files sns-js #429

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

lmuntaner
Copy link
Contributor

@lmuntaner lmuntaner commented Sep 27, 2023

Motivation

Use the new fields for the Neurons' Fund enhancements.

In this PR, upgrade the candid files for sns canisters.

Changes

Automatic changes

Script ./scripts/import-candid ../ic. It uses the local copy of the IC repo.

  • Update candid files. Files with extension .did.

Script ./scripts/compile-idl-js.

  • Update related candid types and JS files.

Manual changes

Only the change in src/index.ts

  • Export new type NeuronsFundParticipationConstraints that has the maximum commitment of the Neurons' Fund.

Tests

  • Fixed a mock data with new parameters.

@lmuntaner
Copy link
Contributor Author

@dskloetd @mstrasinskis please review

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger 2.92 KB (0%)
@dfinity/ledger-icp -19 B (0%)
@dfinity/nns 29.79 KB (+0.34% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.85 KB (+0.91% 🔺)
@dfinity/utils 3.81 KB (0%)
@dfinity/ic-management 1.94 KB (0%)

@dskloetd
Copy link
Collaborator

Were some or all of the changes in this PR automated by a script?
If yes, can you put the exact script invocation in the PR description?
And if there were also manual changes, can you clearly describe what was automated and what was manual?

@lmuntaner
Copy link
Contributor Author

Were some or all of the changes in this PR automated by a script? If yes, can you put the exact script invocation in the PR description? And if there were also manual changes, can you clearly describe what was automated and what was manual?

Done! Ready for review

Copy link
Collaborator

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmuntaner lmuntaner enabled auto-merge (squash) September 27, 2023 14:04
@lmuntaner lmuntaner merged commit 1a11bfb into main Sep 27, 2023
@lmuntaner lmuntaner deleted the GIX-1909_LM_update-sns-js-candid branch September 27, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants