Rename ICRC-1 memo to icrc1Memo

[dskloetd]

Motivation

The ICP ledger canister offers different interfaces to make transfers. The newer ICRC-1 interface and the older "legacy" interface.
Both interfaces allow passing a memo field in the parameters.
However these fields called memo have absolutely nothing to do with each other.
When fetching the transaction later, you get 2 unrelated fields called "memo" and "icrc1_memo".

When using the ICRC-1 interface it is not possible to set the memo field and when using the "legacy" interface it is not possible to set the icrc1_memo field.

Given how surprising and confusing this is, I believe it was a mistake to give these fields the same name in the method parameters.

Changes

1. Rename the memo field in the ICRC-1 method parameters to icrc1Memo, in the ic-js repo.
2. Add comments warning about the two fields being completely unrelated.

Tests

Existing unit test have been updated where necessary.

[github-actions]

size-limit report 📦

Path	Size
@dfinity/ckbtc	6.38 KB (0%)
@dfinity/cmc	1.01 KB (0%)
@dfinity/ledger	2.92 KB (0%)
@dfinity/ledger-icp	-19 B (0%)
@dfinity/nns	29.69 KB (+0.02% 🔺)
@dfinity/nns-proto	76.3 KB (0%)
@dfinity/sns	14.72 KB (0%)
@dfinity/utils	3.81 KB (0%)
@dfinity/ic-management	1.94 KB (0%)

[lmuntaner]

Thanks!

[peterpeterparker]

Not sure renaming the field really makes it more clear that both field are unrelated. I mean "memo" and "icrc1_memo" are still "memo". In addition, the lib "ledger" is meant for icrc-1 and this is a breaking changes. So personally rather like that we do not rename it.

[dskloetd]

I've reverted the changes in the ledger package but kept the warning comments and kept the changes in the nns package.

[peterpeterparker]

Thanks @dskloetd