Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump all dependencies including TypeScript v5 #422

Merged
merged 2 commits into from
Sep 22, 2023
Merged

build: bump all dependencies including TypeScript v5 #422

merged 2 commits into from
Sep 22, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Sep 22, 2023 •
edited
Loading

Changes

  • bump all dependencies including TypeScript v5 (which we are already using in NNS dapp)
  • format code changes due to newer prettier version
  • add a ts-ignore in debounce utils

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.38 KB (-1.07% 🔽)
@dfinity/cmc 1.01 KB (-8.15% 🔽)
@dfinity/ledger 2.92 KB (-3.24% 🔽)
@dfinity/nns 29.69 KB (+0.15% 🔺)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 14.72 KB (-1.08% 🔽)
@dfinity/utils 3.81 KB (-2.41% 🔽)
@dfinity/ic-management 1.94 KB (-4.75% 🔽)

@peterpeterparker
Copy link
Member Author

@lmuntaner interesting almost all libs get lighter here

lmuntaner
lmuntaner approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterpeterparker peterpeterparker merged commit 7174c98 into main Sep 22, 2023
9 checks passed
@peterpeterparker peterpeterparker deleted the build/bump-all-dependencies branch September 22, 2023 08:30
@dskloetd dskloetd mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner