Merge branch 'main' into build/did-generated

dfinity · Apr 2, 2024 · c68112b · c68112b
2 parents 69ffae2 + cf81af4
commit c68112b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
@@ -53,7 +53,7 @@ jobs:
       - name: Install didc
         run: |
           mkdir -p .bin
-          curl -L https://github.com/dfinity/candid/releases/download/2023-09-27/didc-linux64 > .bin/didc
+          curl -L https://github.com/dfinity/candid/releases/download/2024-02-27/didc-linux64 > .bin/didc
           chmod +x .bin/didc
       - name: Add didc to the PATH
         run: echo "${PWD}/.bin" >> $GITHUB_PATH

diff --git a/.github/workflows/update-ic.yml b/.github/workflows/update-ic.yml
@@ -44,7 +44,7 @@ jobs:
           # Gets didc
           echo "$PATH" | tr : "\n"
           mkdir -p "$HOME/.local/bin"
-          curl -Lf https://github.com/dfinity/candid/releases/download/2023-09-27/didc-linux64 | install -m 755 /dev/stdin "$HOME/.local/bin/didc"
+          curl -Lf https://github.com/dfinity/candid/releases/download/2024-02-27/didc-linux64 | install -m 755 /dev/stdin "$HOME/.local/bin/didc"
           # Gets prettier in a minute
           npm ci
           # Gets candid

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,21 +1,22 @@
 # 2024.xx.yy-hhmmZ
 
+# Breaking changes
+
+- Protocol buffers for hardware wallet transactions are no longer supported. Internet Computer Ledger app 2.4.9 or later is now required.
+- GovernanceCanister.listNeurons no longer throws an error when called with `certified: false` for hardware wallet transactions.
+
 ## Features
 
 - ICP transactions, as provided by the Index canister, have been extended to include their block timestamp information.
-- When no fee is specified when making an ICP transaction, use the mandatory fee
-  of 10000 e8s (0.0001 ICP) instead of fetching the fee from the network.
+- When no fee is specified when making an ICP transaction, use the mandatory fee of 10000 e8s (0.0001 ICP) instead of fetching the fee from the network.
 - Remove hardware wallet specific code paths from `@dfinity/ledger-icp`.
 - Remove hardware wallet specific options from LedgerCanister.
 - Remove dependency on `@dfinity/nns-proto` from `@dfinity/ledger-icp`.
 - Remove hardware wallet specific code and `@dfinity/nns-proto` dependency from `@dfinity/nns`.
 
-# Breaking changes
+## Build
 
-- Protocol buffers for hardware wallet transactions are no longer supported.
-  Internet Computer Ledger app 2.4.9 or later is now required.
-- GovernanceCanister.listNeurons no longer throws an error when called with
-  `certified: false` for hardware wallet transactions.
+- Upgrade `didc` to `0.3.7` that converts candid files into JS and TS.
 
 # 2024.03.25-1430Z
 

diff --git a/scripts/compile-idl-js b/scripts/compile-idl-js
@@ -4,10 +4,10 @@
 
 set -euo pipefail
 
-if [ "$(didc --version)" != "didc 0.3.5" ]; then
+if [ "$(didc --version)" != "didc 0.3.7" ]; then
   {
-    echo "didc version 0.3.5 is required. To install it on Mac:"
-    echo "curl -Lf https://github.com/dfinity/candid/releases/download/2023-09-27/didc-macos -o install_didc"
+    echo "didc version 0.3.7 is required. To install it on Mac:"
+    echo "curl -Lf https://github.com/dfinity/candid/releases/download/2024-02-27/didc-macos -o install_didc"
     echo "install -m 755 install_didc /$HOME/.local/bin/didc"
   } >&2
   exit 1