remove default includeEmptyNeurons=false from getNeuron and set test …

…to includeEmptyNeurons: false
dfinity · Oct 10, 2024 · bbebe15 · bbebe15
1 parent 9573096
commit bbebe15
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/nns/src/governance.canister.spec.ts b/packages/nns/src/governance.canister.spec.ts
@@ -756,13 +756,13 @@ describe("GovernanceCanister", () => {
       const response = await governance.getNeuron({
         certified: true,
         neuronId,
-        includeEmptyNeurons: true,
+        includeEmptyNeurons: false,
       });
 
       expect(certifiedService.list_neurons).toBeCalledWith({
         neuron_ids: new BigUint64Array([neuronId]),
         include_neurons_readable_by_caller: false,
-        include_empty_neurons_readable_by_caller: [true],
+        include_empty_neurons_readable_by_caller: [false],
         include_public_neurons_in_full_neurons: [],
       });
 

diff --git a/packages/nns/src/governance.canister.ts b/packages/nns/src/governance.canister.ts
@@ -976,7 +976,7 @@ export class GovernanceCanister {
   public getNeuron = async ({
     certified = true,
     neuronId,
-    includeEmptyNeurons = false,
+    includeEmptyNeurons,
   }: {
     certified: boolean;
     neuronId: NeuronId;
@@ -985,13 +985,11 @@ export class GovernanceCanister {
     // The governance canister exposes two functions "get_neuron_info" and "get_full_neuron" that could probably be used to fetch the neuron details too.
     // However historically this function has been resolved with a single call "list_neurons".
 
-    //Visibility is not provided by old oldListNeuronsCertifiedService, and we pass include empty neurons to get correct visibility
+    //Visibility is not provided by oldListNeuronsCertifiedService, and we pass include empty neurons to have option to use the certifiedService
     const [neuron]: NeuronInfo[] = await this.listNeurons({
       certified,
       neuronIds: [neuronId],
-      includeEmptyNeurons: includeEmptyNeurons
-        ? includeEmptyNeurons
-        : undefined,
+      includeEmptyNeurons,
     });
 
     return neuron;