Merge branch 'main' into feat/xdr_conversion_rate-neuron-funds

.github/workflows/checks.yml

@@ -53,7 +53,7 @@ jobs:
       - name: Install didc
         run: |
           mkdir -p .bin
-          curl -L https://github.com/dfinity/candid/releases/download/2023-09-27/didc-linux64 > .bin/didc
+          curl -L https://github.com/dfinity/candid/releases/download/2024-02-27/didc-linux64 > .bin/didc
           chmod +x .bin/didc
       - name: Add didc to the PATH
         run: echo "${PWD}/.bin" >> $GITHUB_PATH

.github/workflows/update-ic.yml

@@ -44,7 +44,7 @@ jobs:
           # Gets didc
           echo "$PATH" | tr : "\n"
           mkdir -p "$HOME/.local/bin"
-          curl -Lf https://github.com/dfinity/candid/releases/download/2023-09-27/didc-linux64 | install -m 755 /dev/stdin "$HOME/.local/bin/didc"
+          curl -Lf https://github.com/dfinity/candid/releases/download/2024-02-27/didc-linux64 | install -m 755 /dev/stdin "$HOME/.local/bin/didc"
           # Gets prettier in a minute
           npm ci
           # Gets candid

CHANGELOG.md

@@ -1,21 +1,22 @@
 # 2024.xx.yy-hhmmZ
 
+# Breaking changes
+
+- Protocol buffers for hardware wallet transactions are no longer supported. Internet Computer Ledger app 2.4.9 or later is now required.
+- GovernanceCanister.listNeurons no longer throws an error when called with `certified: false` for hardware wallet transactions.
+
 ## Features
 
 - ICP transactions, as provided by the Index canister, have been extended to include their block timestamp information.
-- When no fee is specified when making an ICP transaction, use the mandatory fee
-  of 10000 e8s (0.0001 ICP) instead of fetching the fee from the network.
+- When no fee is specified when making an ICP transaction, use the mandatory fee of 10000 e8s (0.0001 ICP) instead of fetching the fee from the network.
 - Remove hardware wallet specific code paths from `@dfinity/ledger-icp`.
 - Remove hardware wallet specific options from LedgerCanister.
 - Remove dependency on `@dfinity/nns-proto` from `@dfinity/ledger-icp`.
 - Remove hardware wallet specific code and `@dfinity/nns-proto` dependency from `@dfinity/nns`.
 
-# Breaking changes
+## Build
 
-- Protocol buffers for hardware wallet transactions are no longer supported.
-  Internet Computer Ledger app 2.4.9 or later is now required.
-- GovernanceCanister.listNeurons no longer throws an error when called with
-  `certified: false` for hardware wallet transactions.
+- Upgrade `didc` to `0.3.7` that converts candid files into JS and TS.
 
 # 2024.03.25-1430Z
 

packages/ckbtc/candid/minter.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -304,3 +305,5 @@ export interface _SERVICE {
     { Ok: Array<UtxoStatus> } | { Err: UpdateBalanceError }
   >;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/cketh/candid/minter.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface AddCkErc20Token {
@@ -237,3 +238,5 @@ export interface _SERVICE {
     { Ok: RetrieveEthRequest } | { Err: WithdrawalError }
   >;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/cmc/candid/cmc.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export type AccountIdentifier = string;
@@ -114,3 +115,5 @@ export interface _SERVICE {
   >;
   notify_top_up: ActorMethod<[NotifyTopUpArg], NotifyTopUpResult>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/ic-management/candid/ic-management.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export type bitcoin_address = string;
@@ -313,3 +314,5 @@ export interface _SERVICE {
   update_settings: ActorMethod<[update_settings_args], undefined>;
   upload_chunk: ActorMethod<[upload_chunk_args], upload_chunk_result>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/ledger-icp/candid/index.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -110,3 +111,5 @@ export interface _SERVICE {
   ledger_id: ActorMethod<[], Principal>;
   status: ActorMethod<[], Status>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/ledger-icp/candid/ledger.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -298,3 +299,5 @@ export interface _SERVICE {
   transfer: ActorMethod<[TransferArgs], TransferResult>;
   transfer_fee: ActorMethod<[TransferFeeArg], TransferFee>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/ledger-icrc/candid/icrc_index-ng.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -115,3 +116,5 @@ export interface _SERVICE {
   list_subaccounts: ActorMethod<[ListSubaccountsArgs], Array<SubAccount>>;
   status: ActorMethod<[], Status>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/ledger-icrc/candid/icrc_index.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -81,3 +82,5 @@ export interface _SERVICE {
   ledger_id: ActorMethod<[], Principal>;
   list_subaccounts: ActorMethod<[ListSubaccountsArgs], Array<SubAccount>>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/ledger-icrc/candid/icrc_ledger.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -267,3 +268,5 @@ export interface _SERVICE {
   icrc2_approve: ActorMethod<[ApproveArgs], ApproveResult>;
   icrc2_transfer_from: ActorMethod<[TransferFromArgs], TransferFromResult>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/nns/candid/genesis_token.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface AccountState {
@@ -33,3 +34,5 @@ export interface _SERVICE {
   len: ActorMethod<[], number>;
   total: ActorMethod<[], number>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/nns/candid/governance.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface AccountIdentifier {
@@ -814,3 +815,5 @@ export interface _SERVICE {
   transfer_gtc_neuron: ActorMethod<[NeuronId, NeuronId], Result>;
   update_node_provider: ActorMethod<[UpdateNodeProvider], Result>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/nns/candid/governance_test.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface AccountIdentifier {
@@ -815,3 +816,5 @@ export interface _SERVICE {
   update_neuron: ActorMethod<[Neuron], [] | [GovernanceError]>;
   update_node_provider: ActorMethod<[UpdateNodeProvider], Result>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/nns/candid/sns_wasm.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface AddWasmRequest {
@@ -288,3 +289,5 @@ export interface _SERVICE {
     UpdateSnsSubnetListResponse
   >;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/sns/candid/sns_governance.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -552,3 +553,5 @@ export interface _SERVICE {
   manage_neuron: ActorMethod<[ManageNeuron], ManageNeuronResponse>;
   set_mode: ActorMethod<[SetMode], {}>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/sns/candid/sns_governance_test.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface Account {
@@ -566,3 +567,5 @@ export interface _SERVICE {
   set_mode: ActorMethod<[SetMode], {}>;
   update_neuron: ActorMethod<[Neuron], [] | [GovernanceError]>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/sns/candid/sns_root.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface CanisterCallError {
@@ -118,3 +119,5 @@ export interface _SERVICE {
     SetDappControllersResponse
   >;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

packages/sns/candid/sns_swap.d.ts

@@ -1,4 +1,5 @@
 import type { ActorMethod } from "@dfinity/agent";
+import type { IDL } from "@dfinity/candid";
 import type { Principal } from "@dfinity/principal";
 
 export interface BuyerState {
@@ -395,3 +396,5 @@ export interface _SERVICE {
   >;
   restore_dapp_controllers: ActorMethod<[{}], SetDappControllersCallResult>;
 }
+export declare const idlFactory: IDL.InterfaceFactory;
+export declare const init: (args: { IDL: typeof IDL }) => IDL.Type[];

scripts/compile-idl-js

@@ -4,10 +4,10 @@
 
 set -euo pipefail
 
-if [ "$(didc --version)" != "didc 0.3.5" ]; then
+if [ "$(didc --version)" != "didc 0.3.7" ]; then
   {
-    echo "didc version 0.3.5 is required. To install it on Mac:"
-    echo "curl -Lf https://github.com/dfinity/candid/releases/download/2023-09-27/didc-macos -o install_didc"
+    echo "didc version 0.3.7 is required. To install it on Mac:"
+    echo "curl -Lf https://github.com/dfinity/candid/releases/download/2024-02-27/didc-macos -o install_didc"
     echo "install -m 755 install_didc /$HOME/.local/bin/didc"
   } >&2
   exit 1