Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent repeated calls to failed exchanges #264

Merged
merged 7 commits into from
Apr 10, 2024
Merged

fix: Prevent repeated calls to failed exchanges #264

merged 7 commits into from
Apr 10, 2024

Conversation

nategurian
Copy link
Contributor

  • Adds a filter to remove failed exchanges in subsequent out calls within the same get_exchange_rate call
  • Update testing

@nategurian nategurian marked this pull request as ready for review April 9, 2024 17:09
@nategurian nategurian requested a review from a team as a code owner April 9, 2024 17:09
THLO
THLO reviewed Apr 10, 2024
View reviewed changes
src/xrc/src/api.rs Outdated Show resolved Hide resolved
THLO
THLO reviewed Apr 10, 2024
View reviewed changes
src/xrc/src/api/test.rs Outdated Show resolved Hide resolved
THLO
THLO reviewed Apr 10, 2024
View reviewed changes
src/xrc/src/api/test.rs Outdated Show resolved Hide resolved
THLO
THLO reviewed Apr 10, 2024
View reviewed changes
src/xrc/src/api/test.rs Outdated Show resolved Hide resolved
@nategurian nategurian merged commit 458adc3 into main Apr 10, 2024
15 checks passed
@nategurian nategurian deleted the ng/ER-5181 branch April 10, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfinity-ryancroote dfinity-ryancroote dfinity-ryancroote approved these changes

@THLO THLO THLO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nategurian @THLO @dfinity-ryancroote