Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: metrics #341

Merged
merged 6 commits into from
Dec 3, 2024
Merged

refactor: metrics #341

merged 6 commits into from
Dec 3, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Nov 28, 2024 •
edited
Loading

Clean-up metrics:

  1. removed because unused: cyclesWithdrawn, errNoPermission and errHostNotAllowed
  2. Added RejectionCode to errHttpOutcall to be able to track all failed HTTPs outcalls at the protocol level (e.g. a SysTransient error is often due to the infamous No consensus could be reached. Replicas had different responses
  3. Unify metrics related to memory to follow the convention of stable_memory_bytes and heap_memory_bytes

@gregorydemay gregorydemay marked this pull request as ready for review November 28, 2024 14:27
@gregorydemay gregorydemay requested a review from a team as a code owner November 28, 2024 14:27
@gregorydemay gregorydemay requested review from ninegua and THLO November 28, 2024 14:28
@gregorydemay gregorydemay merged commit 284a4dc into main Dec 3, 2024
8 checks passed
@gregorydemay gregorydemay deleted the gdemay/XC-246-metrics-and-logs branch December 3, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninegua ninegua ninegua approved these changes

@THLO THLO Awaiting requested review from THLO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregorydemay @ninegua