Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to cargo-dist 0.10.0 and use standard cargo-dist release script #85

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

ericswanson-dfinity
Copy link
Member

Upgraded to cargo-dist 0.10.0

  • .github/workflows/release.yml is now the stock file that cargo dist init generates
  • Renamed .github/workflows/release-with-github.yml to prepare-release.yml and updated to work with stock cargo-dist release workflow

What I've tested:
Sample PRs generated by prepare-release.yml:

Here is a workflow run that shows what happens if you don't specify a version:

What I haven't tested:
I haven't tested merging a release PR to main and running the cargo release command from the PR description.

That being said, since we're using the stock cargo-dist release workflow now, we can have confidence that the standard release process would work: updating the crate version on main (which merging the release PR would do) and pushing a tag. The prepare-release.yml workflow and cargo release just make that slightly more convenient.

@ericswanson-dfinity ericswanson-dfinity requested review from a team as code owners February 16, 2024 18:13
@ericswanson-dfinity ericswanson-dfinity merged commit e106c7d into main Feb 16, 2024
12 checks passed
@lwshang lwshang deleted the ens/standard-cargo-dist branch February 23, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant