feat: ic binary dependencies are included in tarball #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Several comments that you responded to here: #39 are not addressed in this PR. I re-added some, but may have missed others.
Oops, I should've marked PR as draft. At this point, this is just a revert of a revert. I'll soon push a commit that addresses your review from other PR |
smallstepman
force-pushed
the
revert-43-revert-39-mnl/extensions-include-ic-binaries-in-tarball
branch
from
22bb4bf to
14ed7b3
Compare
smallstepman
force-pushed
the
revert-43-revert-39-mnl/extensions-include-ic-binaries-in-tarball
branch
from
14ed7b3 to
1d6bf2f
Compare
smallstepman
changed the title
ericswanson-dfinity
requested changes
Aug 8, 2023
Co-authored-by: Eric Swanson <[email protected]>
smallstepman
force-pushed
the
revert-43-revert-39-mnl/extensions-include-ic-binaries-in-tarball
branch
from
5951fe3 to
283849b
Compare
ericswanson-dfinity
requested changes
Aug 9, 2023
Co-authored-by: Eric Swanson <[email protected]>
Co-authored-by: Eric Swanson <[email protected]>
smallstepman
commented
Aug 9, 2023
added 2 commits
August 9, 2023 11:24
ericswanson-dfinity
requested changes
Aug 9, 2023
ericswanson-dfinity
approved these changes
Aug 10, 2023
smallstepman
deleted the
revert-43-revert-39-mnl/extensions-include-ic-binaries-in-tarball
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of #39 which got reverted in #43