fix: load dfx.json with extension-defined canister type #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
force-pushed
the
ens/sdk-1832-load-dfx-json-with-extension-canister
branch
2 times, most recently
from
5f3e038 to
a832777
Compare
ericswanson-dfinity
force-pushed
the
ens/sdk-1832-load-dfx-json-with-extension-canister
branch
from
ca8cfdc to
89c17ff
Compare
ericswanson-dfinity
force-pushed
the
ens/sdk-1832-load-dfx-json-with-extension-canister
branch
from
89c17ff to
68844c9
Compare
3 tasks
anchpop
approved these changes
Nov 8, 2024
ericswanson-dfinity
deleted the
ens/sdk-1832-load-dfx-json-with-extension-canister
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dfx nns install,dfx nns import, anddfx sns importall load dfx.json if present. If dfx.json includes a canister with a type defined by an extension, the config loader won't recognize the type unless we provide an ExtensionManager. This PR provides the needed ExtensionManager.Fixes https://dfinity.atlassian.net/browse/SDK-1832