Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo: binary format for function annotations #538

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Mar 20, 2024

I think there's a typo here. Every binary funcann occupies 1 byte, not zero or more.

I think there's a typo here.
@crusso crusso changed the title Update Candid.md typo: binary format for function annotations Mar 20, 2024
@crusso crusso requested a review from chenyan-dfinity March 20, 2024 21:58
@crusso crusso marked this pull request as ready for review March 20, 2024 21:59
Copy link

github-actions bot commented Mar 20, 2024

Name Max Mem (Kb) Encode Decode
blob 4_224 20_464_176 ($\textcolor{green}{-0.00\%}$) 12_084_214 ($\textcolor{red}{0.00\%}$)
btreemap 75_456 4_814_047_219 ($\textcolor{green}{-0.00\%}$) 15_380_666_953 ($\textcolor{red}{0.00\%}$)
nns 192 2_274_916 ($\textcolor{green}{-0.08\%}$) 14_317_956 ($\textcolor{green}{-0.16\%}$)
nns_list_proposal 1_728 19_125_888 ($\textcolor{green}{-0.80\%}$) 182_059_941 ($\textcolor{green}{-0.03\%}$)
option_list 576 7_310_859 ($\textcolor{green}{-0.00\%}$) 33_834_131 ($\textcolor{green}{-0.05\%}$)
text 6_336 28_847_566 ($\textcolor{green}{-0.00\%}$) 17_839_905 ($\textcolor{red}{0.00\%}$)
variant_list 128 7_518_554 ($\textcolor{green}{-0.00\%}$) 25_490_973 ($\textcolor{red}{0.02\%}$)
vec_int16 16_704 168_590_852 ($\textcolor{green}{-0.00\%}$) 1_031_830_179 ($\textcolor{red}{0.00\%}$)
  • Parser cost: 18_351_038
  • Extra args: 3_353_048 ($\textcolor{green}{-0.39\%}$)
Click to see raw report

---------------------------------------------------

Benchmark: blob
  total:
    instructions: 32.55 M (-0.00%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 20.46 M (-0.00%) (change within noise threshold)
    heap_increase: 66 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 12.08 M (0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: text
  total:
    instructions: 46.69 M (-0.00%) (change within noise threshold)
    heap_increase: 99 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 28.85 M (-0.00%) (change within noise threshold)
    heap_increase: 99 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 17.84 M (0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: vec_int16
  total:
    instructions: 1.20 B (-0.00%) (change within noise threshold)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 168.59 M (-0.00%) (change within noise threshold)
    heap_increase: 261 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 1.03 B (0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: btreemap
  total:
    instructions: 20.19 B (-0.00%) (change within noise threshold)
    heap_increase: 1179 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 4.81 B (-0.00%) (change within noise threshold)
    heap_increase: 257 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 15.38 B (0.00%) (change within noise threshold)
    heap_increase: 922 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: option_list
  total:
    instructions: 41.15 M (-0.04%) (change within noise threshold)
    heap_increase: 9 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.31 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 33.83 M (-0.05%) (change within noise threshold)
    heap_increase: 9 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: variant_list
  total:
    instructions: 33.01 M (0.02%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 7.52 M (-0.00%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 25.49 M (0.02%) (change within noise threshold)
    heap_increase: 2 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns
  total:
    instructions: 35.69 M (-0.07%) (change within noise threshold)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

  0. Parsing (scope):
    instructions: 18.35 M (no change)
    heap_increase: 3 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 2.27 M (-0.08%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 14.32 M (-0.16%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: nns_list_proposal
  total:
    instructions: 201.19 M (-0.10%) (change within noise threshold)
    heap_increase: 27 pages (no change)
    stable_memory_increase: 0 pages (no change)

  1. Encoding (scope):
    instructions: 19.13 M (-0.80%) (change within noise threshold)
    heap_increase: 6 pages (no change)
    stable_memory_increase: 0 pages (no change)

  2. Decoding (scope):
    instructions: 182.06 M (-0.03%) (change within noise threshold)
    heap_increase: 21 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------

Benchmark: extra_args
  total:
    instructions: 3.35 M (-0.39%) (change within noise threshold)
    heap_increase: 0 pages (no change)
    stable_memory_increase: 0 pages (no change)

---------------------------------------------------
Successfully persisted results to canbench_results.yml

@chenyan-dfinity chenyan-dfinity merged commit b66a88d into master Apr 11, 2024
5 checks passed
@chenyan-dfinity chenyan-dfinity deleted the crusso-patch-1 branch April 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants