Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IDLValue blob conversion #517

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fix IDLValue blob conversion #517

merged 3 commits into from
Jan 30, 2024

Conversation

chenyan-dfinity
Copy link
Contributor

No description provided.

Copy link

Benchmark for 6414154

Click to view benchmark
Test Base PR %
Blob/&str 635.0±90.46µs 640.5±97.33µs +0.87%
Blob/ByteBuf 357.3±91.48µs 355.7±89.82µs -0.45%
Blob/Bytes 403.7±76.65µs 409.5±78.68µs +1.44%
Blob/String 646.9±244.87µs 658.0±258.41µs +1.72%
Collections/vec (text, nat) 49.4±1.34ms 49.0±2.78ms -0.81%
Collections/vec int 23.3±0.11ms 23.2±0.22ms -0.43%
Collections/vec int64 15.7±0.07ms 15.3±0.15ms -2.55%
Collections/vec nat8 11.6±0.09ms 11.6±0.04ms 0.00%
option list/1024 958.3±36.47µs 957.6±23.06µs -0.07%
profiles/1024 1776.1±23.75µs 1777.0±39.39µs +0.05%
variant list/1024 800.1±58.46µs 787.2±6.15µs -1.61%

Copy link

Benchmark for 712991e

Click to view benchmark
Test Base PR %
Blob/&str 619.2±105.35µs 594.9±88.34µs -3.92%
Blob/ByteBuf 359.7±87.22µs 365.9±86.30µs +1.72%
Blob/Bytes 386.1±63.74µs 357.4±60.02µs -7.43%
Blob/String 334.7±138.64µs 373.3±126.49µs +11.53%
Collections/vec (text, nat) 50.7±1.88ms 50.3±1.26ms -0.79%
Collections/vec int 23.0±0.16ms 23.9±0.31ms +3.91%
Collections/vec int64 15.9±0.48ms 15.8±0.10ms -0.63%
Collections/vec nat8 11.1±0.03ms 11.2±0.11ms +0.90%
option list/1024 983.9±35.71µs 970.8±39.09µs -1.33%
profiles/1024 1817.1±63.74µs 1761.3±48.89µs -3.07%
variant list/1024 790.6±10.65µs 799.9±8.90µs +1.18%

Copy link

Benchmark for 33e1a55

Click to view benchmark
Test Base PR %
Blob/&str 619.2±89.12µs 620.0±97.30µs +0.13%
Blob/ByteBuf 350.6±89.49µs 352.0±84.48µs +0.40%
Blob/Bytes 393.2±75.35µs 397.0±75.71µs +0.97%
Blob/String 641.3±259.23µs 638.8±252.47µs -0.39%
Collections/vec (text, nat) 50.0±1.68ms 49.5±1.33ms -1.00%
Collections/vec int 23.1±0.18ms 23.1±0.12ms 0.00%
Collections/vec int64 15.0±0.07ms 14.8±0.15ms -1.33%
Collections/vec nat8 11.7±0.36ms 11.6±0.03ms -0.85%
option list/1024 959.4±28.49µs 972.3±9.47µs +1.34%
profiles/1024 1785.5±16.90µs 1801.9±44.09µs +0.92%
variant list/1024 803.3±12.91µs 800.9±7.61µs -0.30%

@chenyan-dfinity chenyan-dfinity merged commit aef1e02 into master Jan 30, 2024
5 checks passed
@chenyan-dfinity chenyan-dfinity deleted the fix-blob branch January 30, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants