Bump agent-js and remove workaround for Candid UI #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyan-dfinity
approved these changes
Jan 23, 2024
rvanasa
changed the title
|
Do we want to bump to the latest agent-js as well? |
|
Ready to merge now. Had to wait for a follow-up adjustment to the hostname logic which shipped with Confirmed that everything works as expected locally and on Gitpod after a hard page reload. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates agent-js to the latest version and removes a hotfix used for the latest dfx release.
Pending the next release of
@dfinity/agent.