Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Supply necessary headers for remote dev environments to render correctly #513

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

fxgst
Copy link
Contributor

@fxgst fxgst commented Jan 22, 2024

Developing remotely in e.g. Codespaces or Gitpod environments, the candid UI canister fails to render webpages correctly, because of some missing headers. Related PRs:
#511
dfinity/agent-js#822
before:
before
after:
after

@fxgst fxgst changed the title fix: Supply correct headers for remote dev environments to render correctly fix: Supply necessary headers for remote dev environments to render correctly Jan 23, 2024
@fxgst fxgst marked this pull request as ready for review January 23, 2024 09:49
@fxgst fxgst requested a review from chenyan-dfinity January 23, 2024 09:49
@chenyan-dfinity chenyan-dfinity merged commit 6a0479e into master Jan 23, 2024
4 checks passed
@chenyan-dfinity chenyan-dfinity deleted the elias/fix-remote-development-headers branch January 23, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants