Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine IDLValue::Blob display #497

Merged
merged 5 commits into from
Dec 12, 2023
Merged

refine IDLValue::Blob display #497

merged 5 commits into from
Dec 12, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

Display hex escape for non-ascii blob value

Copy link

github-actions bot commented Dec 1, 2023

Benchmark for cb2ed89

Click to view benchmark
Test Base PR %
Blob/&str 658.9±100.40µs 652.1±98.65µs -1.03%
Blob/ByteBuf 374.8±92.81µs 374.6±91.55µs -0.05%
Blob/Bytes 411.1±76.92µs 413.6±76.61µs +0.61%
Blob/String 680.1±268.09µs 676.3±263.26µs -0.56%
Collections/vec (text, nat) 51.8±1.51ms 51.1±4.29ms -1.35%
Collections/vec int 23.0±0.09ms 22.7±0.19ms -1.30%
Collections/vec int64 17.0±0.09ms 17.1±0.44ms +0.59%
Collections/vec nat8 12.2±0.42ms 12.2±0.10ms 0.00%
option list/1024 986.2±10.25µs 975.7±7.32µs -1.06%
profiles/1024 1907.0±73.33µs 1902.8±48.72µs -0.22%
variant list/1024 796.8±5.49µs 802.8±8.92µs +0.75%

Copy link

github-actions bot commented Dec 1, 2023

Benchmark for b22416e

Click to view benchmark
Test Base PR %
Blob/&str 607.9±82.37µs 605.8±86.51µs -0.35%
Blob/ByteBuf 356.4±88.60µs 358.3±92.67µs +0.53%
Blob/Bytes 392.4±66.00µs 364.0±61.29µs -7.24%
Blob/String 332.7±140.26µs 366.4±127.57µs +10.13%
Collections/vec (text, nat) 51.5±3.48ms 50.8±1.18ms -1.36%
Collections/vec int 22.6±0.09ms 23.4±0.37ms +3.54%
Collections/vec int64 16.6±0.09ms 16.3±0.11ms -1.81%
Collections/vec nat8 11.6±0.17ms 11.8±0.17ms +1.72%
option list/1024 979.4±10.78µs 987.2±32.35µs +0.80%
profiles/1024 1865.6±15.03µs 1866.1±48.68µs +0.03%
variant list/1024 793.6±6.77µs 809.1±14.14µs +1.95%

Copy link

Benchmark for efd6708

Click to view benchmark
Test Base PR %
Blob/&str 627.8±100.26µs 629.2±97.43µs +0.22%
Blob/ByteBuf 359.4±87.37µs 367.2±87.76µs +2.17%
Blob/Bytes 400.6±76.87µs 403.9±77.33µs +0.82%
Blob/String 658.0±257.90µs 653.1±249.25µs -0.74%
Collections/vec (text, nat) 53.6±1.48ms 54.1±2.92ms +0.93%
Collections/vec int 23.2±0.09ms 23.3±0.12ms +0.43%
Collections/vec int64 16.3±0.54ms 15.6±0.08ms -4.29%
Collections/vec nat8 12.1±0.20ms 12.1±0.16ms 0.00%
option list/1024 973.7±9.05µs 980.3±10.43µs +0.68%
profiles/1024 1900.4±36.94µs 1855.3±40.74µs -2.37%
variant list/1024 804.7±9.18µs 801.8±12.74µs -0.36%

@chenyan-dfinity chenyan-dfinity merged commit 2f6f90a into master Dec 12, 2023
5 checks passed
@chenyan-dfinity chenyan-dfinity deleted the blob-display branch December 12, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants