Support combining actors and returning imports #431
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Why do we need this feature? What are we trying to accomplish?
Two use cases:
Requirements
What requirements are necessary to consider this problem solved?
Considered Solutions
What solutions were considered?
Re-implement outside of candid, but the broader community wont' benefit from this
Recommended Solution
What solution are you recommending? Why?
A new
check_file_with_options
API that allows passing custom options. This is extensible in the future for other use-cases. The option will allow actors to be combined in certain cases.Considerations
What impact will this change have on security, performance, users (e.g. breaking changes) or the team (e.g. maintenance costs)?
Minimal impact. This change includes a performance bug fix. The newer functionality is implemented in a backwards compatible manner.