Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JsDoc typo in DelegationIdentity class's fromDelegation method #951

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

georgiod9
Copy link
Contributor

Description

The DelegationIdentity class contains a fat-fingered typo in one of its method's JsDoc. This is fixed by replacing the typo reqyests to the correct form requests.

How Has This Been Tested?

No changes necessary for the testing suite.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.
  • Ran the npm exec prettier:format

@georgiod9 georgiod9 requested a review from a team as a code owner November 4, 2024 10:13
@sa-github-api
Copy link

Dear @georgiod9,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

krpeacock
krpeacock previously approved these changes Dec 12, 2024
@krpeacock krpeacock enabled auto-merge (squash) December 12, 2024 20:17
@krpeacock krpeacock merged commit d59a8b6 into dfinity:main Dec 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants