Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for restricting II auth methods #856

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Mar 14, 2024

Description

Adds new security features from the II login flow for restricting authentication types: https://github.com/dfinity/internet-identity/blob/6c345912457ca93bf3175ce3382a1ddf8ff46eca/docs/ii-spec.md#client-authentication-protocol

New Login method allows developers to restrict users from authenticating using a PIN
image

Also allows onSuccess to pass through the message from the IDP provider, allowing developers to access the new authnMethod field

image

Fixes # (issue)

How Has This Been Tested?

Tested manually after building and installing in https://github.com/krpeacock/auth-client-demo

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner March 14, 2024 17:41
Copy link
Contributor

github-actions bot commented Mar 14, 2024

size-limit report 📦

Path Size
@dfinity/agent 101.81 KB (0%)
@dfinity/candid 13.61 KB (0%)
@dfinity/principal 5.04 KB (0%)
@dfinity/auth-client 92.77 KB (+0.02% 🔺)
@dfinity/assets 93.43 KB (0%)
@dfinity/identity 89.98 KB (0%)
@dfinity/identity-secp256k1 281.19 KB (0%)

docs/CHANGELOG.md Show resolved Hide resolved
packages/auth-client/src/index.ts Outdated Show resolved Hide resolved
@krpeacock krpeacock requested a review from nmattia March 15, 2024 18:22
Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks! Have you tried it out? I think the feature's live in II already

@krpeacock
Copy link
Contributor Author

Looking great, thanks! Have you tried it out? I think the feature's live in II already

Yep - the screenshot was from mainnet

@krpeacock krpeacock enabled auto-merge (squash) March 18, 2024 21:18
@krpeacock krpeacock merged commit 9d48f67 into main Mar 25, 2024
15 checks passed
@krpeacock krpeacock deleted the kai/ii-pin-attributes branch March 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants