Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github.dev and gitpod.io to known hosts #822

Merged
merged 3 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/generated/changelog.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ <h2>Version x.x.x</h2>
<li>feat: enhances `.from` methods on public key classes to support unknown types, including PublicKey instances, ArrayBuffer-like objects, DER encoded public keys, and hex strings. Also introduces a new `bufFromBufLike` util</li>
<li>feat: introduces partial identities from public keys for authentication flows</li>
<li>fix: honor disableIdle flag</li>
<li>fix: add `github.dev` and `gitpod.io` to known hosts</li>
</ul>
<h2>Version 0.20.2</h2>
<ul>
Expand Down
9 changes: 8 additions & 1 deletion packages/agent/src/agent/http/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,14 @@ export class HttpAgent implements Agent {
);
}
// Mainnet and local will have the api route available
rvanasa marked this conversation as resolved.
Show resolved Hide resolved
const knownHosts = ['ic0.app', 'icp0.io', '127.0.0.1', 'localhost'];
const knownHosts = [
'ic0.app',
'icp0.io',
'127.0.0.1',
'localhost',
'github.dev',
rvanasa marked this conversation as resolved.
Show resolved Hide resolved
'gitpod.io',
];
const hostname = location?.hostname;
let knownHost;
if (hostname && typeof hostname === 'string') {
Expand Down
Loading