Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: GitHub actions warning cleanup #819

Merged
merged 6 commits into from
Jan 11, 2024

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Jan 11, 2024

Description

We've had some warnings appearing in the files tab due to not strictly enforcing our linting in CI for issues such as jsdoc conventions. This PR cleans those up.

Also fixes an issue in leb128 where a returned value would be a Uint8Array when it is typed as an ArrayBuffer that I noticed while cleaning up the doc types.

Fixes #811

How Has This Been Tested?

Standard suite

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock requested a review from a team as a code owner January 11, 2024 18:11
Copy link
Contributor

github-actions bot commented Jan 11, 2024

size-limit report 📦

Path Size
@dfinity/agent 99.82 KB (+0.05% 🔺)
@dfinity/candid 13.63 KB (+0.31% 🔺)
@dfinity/principal 5.05 KB (0%)
@dfinity/auth-client 91.72 KB (+0.09% 🔺)
@dfinity/assets 91.93 KB (+0.18% 🔺)
@dfinity/identity 89.07 KB (+0.07% 🔺)
@dfinity/identity-secp256k1 262.53 KB (+0.05% 🔺)

@krpeacock krpeacock enabled auto-merge (squash) January 11, 2024 18:19
@krpeacock krpeacock merged commit eb3fa49 into main Jan 11, 2024
48 checks passed
@krpeacock krpeacock deleted the kai/github-actions-warning-cleanup branch January 11, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing JSdoc
1 participant