Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Limit the delegation depth of read_state certificates to 1 #813

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

oggy-dfin
Copy link
Member

This reflects the following change in the interface spec: dfinity/interface-spec#239

How Has This Been Tested?

The new test is in certificate.test.js. It uses a blob (in with_subnet_key.bin) that contains a certificate recorded from an actual interaction with the II subnet. The certificate is then mangled to serve as its own delegation; this passed before the change in this PR.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

This reflects the following change in the interface spec:
dfinity/interface-spec#239
@oggy-dfin oggy-dfin requested a review from a team as a code owner December 12, 2023 12:12
@krpeacock krpeacock merged commit 722fe51 into dfinity:main Dec 12, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants