Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: round ingress expiry #788

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 26, 2023

Description

In order to more effectively provide caching options in the boundary nodes, it is useful to limit the areas of randomness among cacheable query results. This feature will set expiries to 5 minutes, rounded down to the nearest minute.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

size-limit report 📦

Path Size
@dfinity/agent 88.4 KB (+0.02% 🔺)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.68 KB (-0.01% 🔽)
@dfinity/assets 90.81 KB (-0.01% 🔽)
@dfinity/identity 89.96 KB (-0.01% 🔽)
@dfinity/identity-secp256k1 233.63 KB (+0.01% 🔺)

@krpeacock krpeacock marked this pull request as ready for review October 30, 2023 22:48
@krpeacock krpeacock requested a review from a team as a code owner October 30, 2023 22:48
@krpeacock
Copy link
Contributor Author

Note: This change makes it easy to reproduce what would have been an edge case before. By rounding the expiry, it means that sequential update calls may return the same response if the agent's disableNonce option is set.

This is not yet the default, so the scope of this PR doesn't need to cover that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant