Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replaces use of localhost with 127.0.0.1 for better node 18 support #787

Merged
merged 6 commits into from
Oct 26, 2023
Merged

chore: replaces use of localhost with 127.0.0.1 for better node 18 support #787

merged 6 commits into from
Oct 26, 2023

Conversation

krpeacock
Copy link
Contributor

@krpeacock krpeacock commented Oct 26, 2023 •
edited
Loading

This also fixes compatibility with webpack and parcel proxies to icx-proxy

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@krpeacock krpeacock marked this pull request as ready for review October 26, 2023 16:48
@krpeacock krpeacock requested a review from a team as a code owner October 26, 2023 16:48
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 88.19 KB (-0.01% 🔽)
@dfinity/candid 13.58 KB (0%)
@dfinity/principal 5.2 KB (0%)
@dfinity/auth-client 92.63 KB (0%)
@dfinity/assets 90.6 KB (0%)
@dfinity/identity 89.91 KB (0%)
@dfinity/identity-secp256k1 233.45 KB (-0.01% 🔽)

@krpeacock krpeacock enabled auto-merge (squash) October 26, 2023 18:15
dfx-json
dfx-json approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dfx-json dfx-json left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work. lgtm 👍

@krpeacock krpeacock merged commit 2d195f8 into main Oct 26, 2023
12 checks passed
@krpeacock krpeacock deleted the kyle/replace-localhost branch October 26, 2023 18:47
This was referenced Sep 6, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfx-json dfx-json dfx-json approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krpeacock @dfx-json