Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating tests for node 20 compatibility #782

Merged
merged 30 commits into from
Nov 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a2c44f9
chore: updating tests for node 20 compatibility
krpeacock Oct 17, 2023
f0a24f3
updating root ts-jest
krpeacock Oct 17, 2023
c354374
chore: updating dependencies, separating e2e workspaces
krpeacock Oct 17, 2023
286ec0e
locking node versions
krpeacock Oct 17, 2023
af31a21
removing package-lock
krpeacock Oct 17, 2023
9e832fe
install latest version of npm
krpeacock Oct 17, 2023
8e21e51
removing node 16
krpeacock Oct 17, 2023
d262a8a
generating package-lock with node 16
krpeacock Oct 17, 2023
a2b4215
chore: updating tests for node 20 compatibility
krpeacock Oct 17, 2023
0913234
updating root ts-jest
krpeacock Oct 17, 2023
9358c18
chore: updating dependencies, separating e2e workspaces
krpeacock Oct 17, 2023
c2cb6f4
locking node versions
krpeacock Oct 17, 2023
c6d8b75
removing package-lock
krpeacock Oct 17, 2023
5955f3c
install latest version of npm
krpeacock Oct 17, 2023
bbe8145
removing node 16
krpeacock Oct 17, 2023
a3e75ba
generating package-lock with node 16
krpeacock Oct 17, 2023
c96435e
Merge branch 'kyle/node-20' of github.com:dfinity/agent-js into kyle/…
krpeacock Nov 6, 2023
379fa12
fixing merge
krpeacock Nov 6, 2023
343652a
updating types for bls-verify
krpeacock Nov 6, 2023
1a364da
moving inline snapshots to snapshot files
krpeacock Nov 6, 2023
35d64ff
Merge branch 'main' into kyle/node-20
krpeacock Nov 8, 2023
d0f388e
removes tslint in favor of eslint
krpeacock Nov 8, 2023
c485962
updating snapshots
krpeacock Nov 8, 2023
7842154
eslint-prettier
krpeacock Nov 8, 2023
60075c9
npm ci
krpeacock Nov 8, 2023
4abb7d9
eslint rules
krpeacock Nov 8, 2023
8c9edb0
request id eslint
krpeacock Nov 8, 2023
a580c4c
changelog
krpeacock Nov 8, 2023
b9aae63
Merge branch 'main' into kyle/node-20
krpeacock Nov 13, 2023
4287720
Update index.test.ts.snap
krpeacock Nov 13, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
spec:
- '0.16.1'
node:
- 16
- 18

steps:
- uses: actions/checkout@v2
Expand All @@ -28,9 +28,11 @@ jobs:
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm@9
- run: npm install -g npm

- run: npm install
- run: pushd e2e/browser && npm install && popd
- run: pushd e2e/node && npm install && popd

# build monorepo incl. each subpackage
- run: npm run build --workspaces --if-present
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
spec:
- release-0.16 # https://github.com/dfinity-lab/ic-ref/tree/release-0.16
node:
- 14
- 20
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: npm install -g npm@9
- run: npm install -g npm
- run: npm install
- run: npm run lint --workspaces --if-present
4 changes: 2 additions & 2 deletions .github/workflows/mitm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
spec:
- '0.16.1'
node:
- 16
- 20

steps:
- uses: actions/checkout@v2
Expand All @@ -29,7 +29,7 @@ jobs:
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm@9
- run: npm install -g npm

- run: npm install

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/prettier.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ jobs:
spec:
- release-0.16 # https://github.com/dfinity-lab/ic-ref/tree/release-0.16
node:
- 14
- 20
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node }}
- run: npm install -g npm@9
- run: npm install prettier pretty-quick
- run: npm install -g npm
- run: npm ci
- run: npm run prettier:check

aggregate:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/size-limit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
CI_JOB_NUMBER: 1
steps:
- uses: actions/checkout@v1
- run: npm install -g npm@9
- run: npm install -g npm
# - run: npm run size-limit --workspaces --if-present

# commented out until the job can be configured
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
spec:
- '0.16.1'
node:
- 14
- 16
- 18
- 20

steps:
- uses: actions/checkout@v2
Expand All @@ -29,9 +29,9 @@ jobs:
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm@9
- run: npm install -g npm

- run: npm ci
- run: npm install

# build monorepo incl. each subpackage
- run: npm run build --workspaces --if-present
Expand Down
1 change: 0 additions & 1 deletion .husky/.gitignore

This file was deleted.

4 changes: 0 additions & 4 deletions .husky/pre-commit

This file was deleted.

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18.16
v20.9.0
4 changes: 2 additions & 2 deletions demos/sample-javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@
"stream-browserify": "^3.0.0",
"ts-node": "^10.8.2",
"util": "^0.12.3",
"webpack": "^5.76.0",
"webpack-cli": "^4.5.0",
"webpack-dev-server": "^4.0.0-beta.0",
"webpack": "^5.76.0"
"webpack-dev-server": "^4.0.0-beta.0"
}
}
1 change: 1 addition & 0 deletions docs/generated/changelog.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ <h1>Agent-JS Changelog</h1>
<section>
<h2>Version x.x.x</h2>
<ul>
<li>chore: cleanup for node 20 development in agent-js</li>
<li>fix: canisterStatus returns full list of controllers</li>
<ul>
<strong>feat!: node signature verification</strong
Expand Down
2 changes: 1 addition & 1 deletion e2e/node/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"size-limit": "^8.2.6",
"text-encoding": "^0.7.0",
"ts-node": "^10.8.2",
"typescript": "^4.7.4",
"typescript": "^5.2.2",
"vitest": "^0.34.6",
"webcrypto-core": "^1.7.5"
}
Expand Down
1 change: 0 additions & 1 deletion jest.config.base.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import type { Config } from '@jest/types';

const config: Config.InitialOptions = {
verbose: true,
testPathIgnorePatterns: ['/node_modules/', '/lib/', '/dist/', '/docs/'],
testMatch: ['**/src/**/?(*.)+(spec|test).[jt]s?(x)'],
};
Expand Down
Loading
Loading