fix: add @dfinity/principal as a peerDependency where needed (#752)

* fix: add `@dfinity/principal` as a peerDependency where needed * Update changelog
dfinity · Aug 15, 2023 · 83e4d34 · 83e4d34
1 parent 7bf4348
commit 83e4d34
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/docs/generated/changelog.html b/docs/generated/changelog.html
@@ -12,6 +12,7 @@ <h1>Agent-JS Changelog</h1>
     <section>
       <h2>Version x.x.x</h2>
       <ul>
+        <li>Fix: add `@dfinity/principal` as a peerDependency to `assets` and `candid`.</li>
         <li>
           Feat: HttpAgent now uses a default address of https://icp-api.io. Users will be warned for
           not setting a host, but the code will default to mainnet.

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/assets/package.json b/packages/assets/package.json
@@ -51,6 +51,7 @@
   },
   "peerDependencies": {
     "@dfinity/agent": "^0.18.1",
+    "@dfinity/principal": "^0.18.1",
     "js-sha256": "0.9.0"
   },
   "dependencies": {

diff --git a/packages/candid/package.json b/packages/candid/package.json
@@ -47,6 +47,9 @@
     "test": "jest",
     "test:coverage": "jest --verbose --collectCoverage"
   },
+  "peerDependencies": {
+    "@dfinity/principal": "^0.18.1"
+  },
   "devDependencies": {
     "@types/jest": "^28.1.4",
     "@typescript-eslint/eslint-plugin": "^5.30.5",